- Linting (ESLint): Stricter rules (or switch to warning)

- Breaking internal API change: `updateGripCursor` moved to be class method of Selector rather than instance method
- Breaking internal API change: `subpathIsClosed` moved to be class method of `Path` rather than instance method
- Refactoring: Reuse utilities base64 encoder for SVG icons plugin
- Docs (JSDoc): Fix return of the `mouseUp` (can also be an object) and `mouseDown` (may also be a boolean) of `pathActions`; other JSDoc additions/improvements
This commit is contained in:
Brett Zamir
2018-11-07 14:51:50 +08:00
parent 901c9547fe
commit 7c470e9909
126 changed files with 2081 additions and 1373 deletions

View File

@@ -1,6 +1,20 @@
// Adapted from https://www.npmjs.com/package/sinon-test
export default function ({sinon, QUnit}) {
/**
* @external QUnit
*/
/**
* @external sinon
*/
/**
* Adds methods to Sinon using a QUnit implementation.
* @param {PlainObject} implementations
* @param {external:sinon} implementations.sinon
* @param {external:QUnit} implementations.QUnit
* @returns {undefined}
*/
export default function sinonQunit ({sinon, QUnit}) {
sinon.assert.fail = function (msg) {
QUnit.ok(false, msg);
};
@@ -10,7 +24,7 @@ export default function ({sinon, QUnit}) {
};
const qTest = QUnit.test;
QUnit.test = function (testName, callback) {
QUnit.test = function (testName, callback) { // eslint-disable-line promise/prefer-await-to-callbacks
return qTest(testName, sinon.test(callback));
};
}