- Linting (ESLint): Stricter rules (or switch to warning)

- Breaking internal API change: `updateGripCursor` moved to be class method of Selector rather than instance method
- Breaking internal API change: `subpathIsClosed` moved to be class method of `Path` rather than instance method
- Refactoring: Reuse utilities base64 encoder for SVG icons plugin
- Docs (JSDoc): Fix return of the `mouseUp` (can also be an object) and `mouseDown` (may also be a boolean) of `pathActions`; other JSDoc additions/improvements
This commit is contained in:
Brett Zamir
2018-11-07 14:51:50 +08:00
parent 901c9547fe
commit 7c470e9909
126 changed files with 2081 additions and 1373 deletions

View File

@@ -8,6 +8,10 @@ QUnit.log((details) => {
}
});
/**
* Set up tests, supplying mock data.
* @returns {undefined}
*/
function setUp () {
units.init(
/**
@@ -35,7 +39,7 @@ QUnit.test('Test svgedit.units.shortFloat()', function (assert) {
setUp();
assert.ok(units.shortFloat);
assert.equal(typeof units.shortFloat, typeof function () {});
assert.equal(typeof units.shortFloat, typeof function () { /* */ });
const {shortFloat} = units;
assert.equal(shortFloat(0.00000001), 0);
@@ -51,7 +55,7 @@ QUnit.test('Test svgedit.units.isValidUnit()', function (assert) {
setUp();
assert.ok(units.isValidUnit);
assert.equal(typeof units.isValidUnit, typeof function () {});
assert.equal(typeof units.isValidUnit, typeof function () { /* */ });
const {isValidUnit} = units;
assert.ok(isValidUnit('0'));
@@ -79,7 +83,7 @@ QUnit.test('Test svgedit.units.convertUnit()', function (assert) {
setUp();
assert.ok(units.convertUnit);
assert.equal(typeof units.convertUnit, typeof function () {});
assert.equal(typeof units.convertUnit, typeof function () { /* */ });
// cm in default setup
assert.equal(units.convertUnit(42), 1.1113);
assert.equal(units.convertUnit(42, 'px'), 42);