github/svgedit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

- Refactoring: Avoid redundant creation of text node for strings when passing to append

Browse Source
This commit is contained in:
Brett Zamir
2020-01-04 16:43:03 +08:00
parent 332a562876
commit 92f8a5be57
3 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
cypress/integration/unit/draw.js
View File

@@ -69,19 +69,19 @@ describe('draw.Drawing', function () {
const setupSVGWith3Layers = function (svgElem) { const setupSVGWith3Layers = function (svgElem) {
const layer1 = document.createElementNS(NS.SVG, 'g'); const layer1 = document.createElementNS(NS.SVG, 'g');
const layer1Title = document.createElementNS(NS.SVG, 'title'); const layer1Title = document.createElementNS(NS.SVG, 'title');
layer1Title.append(document.createTextNode(LAYER1)); layer1Title.append(LAYER1);
layer1.append(layer1Title); layer1.append(layer1Title);
svgElem.append(layer1); svgElem.append(layer1);
const layer2 = document.createElementNS(NS.SVG, 'g'); const layer2 = document.createElementNS(NS.SVG, 'g');
const layer2Title = document.createElementNS(NS.SVG, 'title'); const layer2Title = document.createElementNS(NS.SVG, 'title');
layer2Title.append(document.createTextNode(LAYER2)); layer2Title.append(LAYER2);
layer2.append(layer2Title); layer2.append(layer2Title);
svgElem.append(layer2); svgElem.append(layer2);
const layer3 = document.createElementNS(NS.SVG, 'g'); const layer3 = document.createElementNS(NS.SVG, 'g');
const layer3Title = document.createElementNS(NS.SVG, 'title'); const layer3Title = document.createElementNS(NS.SVG, 'title');
layer3Title.append(document.createTextNode(LAYER3)); layer3Title.append(LAYER3);
layer3.append(layer3Title); layer3.append(layer3Title);
svgElem.append(layer3); svgElem.append(layer3);

2
cypress/integration/unit/recalculate.js
View File

@@ -89,7 +89,7 @@ describe('recalculate', function () {
tspan.setAttribute('x', '200'); tspan.setAttribute('x', '200');
tspan.setAttribute('y', '150'); tspan.setAttribute('y', '150');
const theText = document.createTextNode('Foo bar'); const theText = 'Foo bar';
tspan.append(theText); tspan.append(theText);
elem.append(tspan); elem.append(tspan);
svg.append(elem); svg.append(elem);

4
editor/extensions/ext-imagelib.js
View File

@@ -232,7 +232,7 @@ export default {
$(this).html( $(this).html(
$('<span>').append( $('<span>').append(
$('<img>').attr('src', curMeta.preview_url), $('<img>').attr('src', curMeta.preview_url),
document.createTextNode(title) title
) )
); );
} else { } else {
@@ -254,7 +254,7 @@ export default {
if (curMeta && curMeta.preview_url) { if (curMeta && curMeta.preview_url) {
entry = $('<span>').append( entry = $('<span>').append(
$('<img>').attr('src', curMeta.preview_url), $('<img>').attr('src', curMeta.preview_url),
document.createTextNode(title) title
); );
} else { } else {
entry = $('<img>').attr('src', response); entry = $('<img>').attr('src', response);