github/svgedit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix Issue 489: The href attribute on image elements was being created without a prefix.

Browse Source 
setAttributeNS(nsuri, name, value) takes a qname, not a localname as its 2nd argument. (This is not to be confused with getAttributeNS(nsuri, name), which takes a localname as its 2nd argument.)

git-svn-id: http://svg-edit.googlecode.com/svn/trunk@1410 eee81c28-f429-11dd-99c0-75d572ba1ddd
This commit is contained in:
Jacques Distler
2010-02-18 17:41:07 +00:00
parent 78c9ae4ad7
commit 98be8d5f81
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
editor/svgcanvas.js
View File

@@ -1380,7 +1380,7 @@ function BatchCommand(text) {
// TODO: we simply check if the first character is a #, is this bullet-proof? // TODO: we simply check if the first character is a #, is this bullet-proof?
if (href[0] != "#") { if (href[0] != "#") {
// remove the attribute (but keep the element) // remove the attribute (but keep the element)
node.setAttributeNS(xlinkns, "href", ""); node.setAttributeNS(xlinkns, "xlink:href", "");
node.removeAttributeNS(xlinkns, "href"); node.removeAttributeNS(xlinkns, "href");
} }
} }
@@ -2951,7 +2951,7 @@ function BatchCommand(text) {
"style": "pointer-events:inherit" "style": "pointer-events:inherit"
} }
}); });
newImage.setAttributeNS(xlinkns, "href", last_good_img_url); newImage.setAttributeNS(xlinkns, "xlink:href", last_good_img_url);
preventClickDefault(newImage); preventClickDefault(newImage);
break; break;
case "square": case "square":
@@ -5600,7 +5600,7 @@ function BatchCommand(text) {
if(m) { if(m) {
var url = decodeURIComponent(m[1]); var url = decodeURIComponent(m[1]);
$(new Image()).load(function() { $(new Image()).load(function() {
image.setAttributeNS(xlinkns,'href',url); image.setAttributeNS(xlinkns,'xlink:href',url);
}).attr('src',url); }).attr('src',url);
} }
} }
@@ -6888,7 +6888,7 @@ function BatchCommand(text) {
// } // }
} else if (attr == "#href") { } else if (attr == "#href") {
elem.setAttributeNS(xlinkns, "href", newValue); elem.setAttributeNS(xlinkns, "xlink:href", newValue);
} }
else elem.setAttribute(attr, newValue); else elem.setAttribute(attr, newValue);
if (i==0) if (i==0)
@@ -7659,7 +7659,7 @@ function BatchCommand(text) {
'style':'pointer-events:none' 'style':'pointer-events:none'
}); });
} }
bg_img.setAttributeNS(xlinkns, "href", url); bg_img.setAttributeNS(xlinkns, "xlink:href", url);
bg.appendChild(bg_img); bg.appendChild(bg_img);
} else if(bg_img) { } else if(bg_img) {
bg_img.parentNode.removeChild(bg_img); bg_img.parentNode.removeChild(bg_img);