(INCOMPLETE: ES6 Module conversion and linting)

- Breaking change: Require `new` with `EmbeddedSVGEdit` (allows us to use `class` internally)
- Breaking change: If `svgcanvas.setUiStrings` must now be called if not using editor in order
    to get strings (for sake of i18n) (and if using path.js alone, must also have its `setUiStrings` called)
- Breaking change (ext-overview-window): Avoid global `overviewWindowGlobals`
- Breaking change (ext-imagelib): Change to object-based encoding for namespacing of
    messages (though keep stringifying/parsing ourselves until we remove IE9 support)
- Breaking change: Rename `jquery.js` to `jquery.min.js`
- Breaking change: Remove `scoped` attribute from `style`; it is now deprecated and
    obsolete; also move to head (after other stylesheets)
- Enhancement: Make SpinButton plugin independent of SVGEdit via
    generic state object for tool_scale
- Enhancement: Remove now unused Python l10n scripts (#238)
- Enhancement: ES6 Modules (including jQuery plugins but not jQuery)
- Enhancement: Further JSDoc (incomplete)
- Enhancement (Optimization): Compress images using imageoptim (and add
    npm script) (per #215)
- Fix: i18nize path.js strings and canvas notifications
- Fix: Attempt i18n for ext-markers
- Refactoring (ext-storage): Move locale info to own file imported by the extension (toward modularity; still should be split into separate files by language and *dynamically* imported, but we'll wait for better `import` support to refactor this)
- Refactoring: For imagelib, add local jQuery copy (using old 1.4.4 as had
    been using from server)
- Refactoring: For MathJax, add local copy (using old 2.3 as had been using from
    server); server had not been working
- Refactoring: Remove `use strict` (implicit in modules)
- Refactoring: Remove trailing whitespace, fix some code within comments
- Refactoring: Expect `jQuery` global rather than `$` for better modularity
    (also to adapt line later once available via `import`)
- Refactoring: Prefer `const` (and then `let`)
- Refactoring: Add block scope keywords closer to first block in which they appear
- Refactoring: Use ES6 `class`
- Refactoring `$.isArray` -> `Array.isArray` and avoid some other jQuery core methods
    with simple VanillaJS replacements
- Refactoring: Use abbreviated object property syntax
- Refactoring: Object destructuring
- Refactoring: Remove `uiStrings` contents in svg-editor.js (obtains from locale)
- Refactoring: Add favicon to embedded API file
- Refactoring: Use arrow functions for brief functions (incomplete)
- Refactoring: Use `Array.prototype.includes`/`String.prototype.includes`;
    `String.prototype.startsWith`, `String.prototype.trim`
- Refactoring: Remove now unnecessary svgutils do/while resetting of variables
- Refactoring: Use shorthand methods for object literals (avoid ": function")
- Refactoring: Avoid quoting object property keys where unnecessary
- Refactoring: Just do truthy/falsey check for lengths in place of comparison to 0
- Refactoring (Testing): Avoid jQuery usage within most test files (defer script,
    also in preparation for future switch to ES6 modules for tests)
- Refactoring: Make jpicker variable declaration indent bearable
- Refactoring (Linting): Finish svgcanvas.js
- Docs: Mention in comment no longer an entry file as before
- Docs: Migrate old config, extensions, and FAQ docs
- Licensing: Indicate MIT is license type of rgbcolor; rename/add license file name for
    jgraduate and screencast to reflect type (Apache 2.0); rename file to reflect it
    contains license information (of type MIT) for Raphael icons

editor/jquery-svg.js

@@ -1,5 +1,3 @@
-/* eslint-disable no-var */
-/* globals $, jQuery */
 /**
  * jQuery module to work with SVG.
  *
@@ -10,9 +8,6 @@
 // Dependencies:
 // 1) jquery
 
-(function () {
-'use strict';
-
 // This fixes $(...).attr() to work as expected with SVG elements.
 // Does not currently use *AttributeNS() since we rarely need that.
 
@@ -23,53 +18,53 @@
 // - If an array is supplied as first parameter, multiple values are returned
 // as an object with values for each given attributes
 
-var proxied = jQuery.fn.attr,
-  // TODO use NS.SVG instead
-  svgns = 'http://www.w3.org/2000/svg';
-jQuery.fn.attr = function (key, value) {
-  var i, attr;
-  var len = this.length;
-  if (!len) { return proxied.apply(this, arguments); }
-  for (i = 0; i < len; ++i) {
-    var elem = this[i];
-    // set/get SVG attribute
-    if (elem.namespaceURI === svgns) {
-      // Setting attribute
-      if (value !== undefined) {
-        elem.setAttribute(key, value);
-      } else if ($.isArray(key)) {
-        // Getting attributes from array
-        var j = key.length, obj = {};
+export default function ($) {
+  const proxied = $.fn.attr,
+    svgns = 'http://www.w3.org/2000/svg';
+  $.fn.attr = function (key, value) {
+    const len = this.length;
+    if (!len) { return proxied.apply(this, arguments); }
+    for (let i = 0; i < len; ++i) {
+      const elem = this[i];
+      // set/get SVG attribute
+      if (elem.namespaceURI === svgns) {
+        // Setting attribute
+        if (value !== undefined) {
+          elem.setAttribute(key, value);
+        } else if (Array.isArray(key)) {
+          // Getting attributes from array
+          const obj = {};
+          let j = key.length;
 
-        while (j--) {
-          var aname = key[j];
-          attr = elem.getAttribute(aname);
-          // This returns a number when appropriate
+          while (j--) {
+            const aname = key[j];
+            let attr = elem.getAttribute(aname);
+            // This returns a number when appropriate
+            if (attr || attr === '0') {
+              attr = isNaN(attr) ? attr : (attr - 0);
+            }
+            obj[aname] = attr;
+          }
+          return obj;
+        }
+        if (typeof key === 'object') {
+          // Setting attributes form object
+          for (const v in key) {
+            elem.setAttribute(v, key[v]);
+          }
+        // Getting attribute
+        } else {
+          let attr = elem.getAttribute(key);
           if (attr || attr === '0') {
             attr = isNaN(attr) ? attr : (attr - 0);
           }
-          obj[aname] = attr;
+          return attr;
         }
-        return obj;
-      }
-      if (typeof key === 'object') {
-        // Setting attributes form object
-        var v;
-        for (v in key) {
-          elem.setAttribute(v, key[v]);
-        }
-      // Getting attribute
       } else {
-        attr = elem.getAttribute(key);
-        if (attr || attr === '0') {
-          attr = isNaN(attr) ? attr : (attr - 0);
-        }
-        return attr;
+        return proxied.apply(this, arguments);
       }
-    } else {
-      return proxied.apply(this, arguments);
     }
-  }
-  return this;
-};
-}());
+    return this;
+  };
+  return $;
+}