- Refactoring: Avoid unnecessary addEventListener false; change internal

jPicker function to class (used with `new`)
- Linting (ESLint): Add `valid-jsdoc` rule and make fixes; but turn off for
  now due to <https://github.com/eslint/eslint/issues/11036> and
  <https://github.com/eslint/eslint/issues/11037>
- Docs (JSDoc): Add some Markdown for variables, line breaks; tighten checks
  for overly generic types (though allow for `.Function` as in
  `jQuery.Function`) and avoid one previously missed instance
This commit is contained in:
Brett Zamir
2018-10-30 23:25:20 +08:00
parent 9b9c900ede
commit aef7b095ef
47 changed files with 1664 additions and 1441 deletions

View File

@@ -148,7 +148,8 @@ export default {
/**
*
* @param {Element[]} [elem=selElems] Array of elements
* @param {Element[]} [elems=selElems] Array of elements
* @returns {undefined}
*/
function findConnectors (elems = selElems) {
const connectors = $(svgcontent).find(connSel);

View File

@@ -101,6 +101,7 @@ export default {
* content into storage)
* 2. Use localStorage to set SVG contents (potentially too large to allow in cookies)
* 3. Use localStorage (where available) or cookies to set preferences.
* @returns {undefined}
*/
function setupBeforeUnloadListener () {
window.addEventListener('beforeunload', function (e) {
@@ -135,7 +136,7 @@ export default {
}
}
}
}, false);
});
}
let loaded = false;

View File

@@ -40,7 +40,7 @@ export default {
message.error = err.message;
}
e.source.postMessage(JSON.stringify(message), '*');
}, false);
});
} catch (err) {
console.log('Error with xdomain message listener: ' + err);
}