github/svgedit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

- Refactoring: Avoid unnecessary addEventListener false; change internal

Browse Source 
jPicker function to class (used with `new`)
- Linting (ESLint): Add `valid-jsdoc` rule and make fixes; but turn off for
  now due to <https://github.com/eslint/eslint/issues/11036> and
  <https://github.com/eslint/eslint/issues/11037>
- Docs (JSDoc): Add some Markdown for variables, line breaks; tighten checks
  for overly generic types (though allow for `.Function` as in
  `jQuery.Function`) and avoid one previously missed instance
This commit is contained in:
Brett Zamir
2018-10-30 23:25:20 +08:00
parent 9b9c900ede
commit aef7b095ef
47 changed files with 1664 additions and 1441 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
screencasts/svgopen2010/script.js
View File

@@ -124,10 +124,10 @@ Slide.prototype = {
const _t = this;
if (canTransition()) {
const l = function (evt) {
elem.parentNode.removeEventListener(transitionEnd, l, false);
elem.parentNode.removeEventListener(transitionEnd, l);
_t._runAutos();
};
elem.parentNode.addEventListener(transitionEnd, l, false);
elem.parentNode.addEventListener(transitionEnd, l);
elem.classList.remove('to-build');
} else {
setTimeout(function () {
@@ -161,17 +161,17 @@ const SlideShow = function (slides) {
this.current = isNaN(this.current) ? 1 : this.current;
const _t = this;
doc.addEventListener('keydown',
function (e) { _t.handleKeys(e); }, false);
function (e) { _t.handleKeys(e); });
doc.addEventListener('mousewheel',
function (e) { _t.handleWheel(e); }, false);
function (e) { _t.handleWheel(e); });
doc.addEventListener('DOMMouseScroll',
function (e) { _t.handleWheel(e); }, false);
function (e) { _t.handleWheel(e); });
doc.addEventListener('touchstart',
function (e) { _t.handleTouchStart(e); }, false);
function (e) { _t.handleTouchStart(e); });
doc.addEventListener('touchend',
function (e) { _t.handleTouchEnd(e); }, false);
function (e) { _t.handleTouchEnd(e); });
window.addEventListener('popstate',
function (e) { _t.go(e.state); }, false);
function (e) { _t.go(e.state); });
this._update();
};
@@ -274,10 +274,10 @@ SlideShow.prototype = {
// Initialize
/* const slideshow = */ new SlideShow(query('.slide')); // eslint-disable-line no-new
document.querySelector('#toggle-counter').addEventListener('click', toggleCounter, false);
document.querySelector('#toggle-size').addEventListener('click', toggleSize, false);
document.querySelector('#toggle-transitions').addEventListener('click', toggleTransitions, false);
document.querySelector('#toggle-gradients').addEventListener('click', toggleGradients, false);
document.querySelector('#toggle-counter').addEventListener('click', toggleCounter);
document.querySelector('#toggle-size').addEventListener('click', toggleSize);
document.querySelector('#toggle-transitions').addEventListener('click', toggleTransitions);
document.querySelector('#toggle-gradients').addEventListener('click', toggleGradients);
const counters = document.querySelectorAll('.counter');
const slides = document.querySelectorAll('.slide');