upgrade and fix associated issues

src/editor/embedapi.js

@@ -111,8 +111,10 @@ svgCanvas.setSvgString('string');
 svgCanvas.setSvgString('string')(function (data, error) {
      if (error) {
      // There was an error
+     throw error
      } else {
      // Handle data
+     console.log(data)
      }
 });
 

src/editor/svgedit.js

@@ -2753,12 +2753,10 @@ editor.init = () => {
   * @returns {external:jQuery}
   */
   const makeFlyoutHolder = function (id, child) {
-    const div = $('<div>', {
+    return $('<div>', {
       class: 'tools_flyout',
       id
     }).appendTo('#svg_editor').append(child);
-
-    return div;
   };
 
   /**

src/svgcanvas/path-actions.js

@@ -165,7 +165,6 @@ export const convertPath = function (pth, toRel) {
       }
       d += pathDSegment(letter, [[x1, y1], [x, y]]);
       break;
-    // eslint-disable-next-line sonarjs/no-duplicated-branches
     case 10: // absolute elliptical arc (A)
       x -= curx;
       y -= cury;

src/svgcanvas/path.js

@@ -77,7 +77,7 @@ export const setLinkControlPoints = function (lcp) {
  * @type {null|module:path.Path}
  * @memberof module:path
 */
-export let path = null; // eslint-disable-line import/no-mutable-exports
+export let path = null;
 
 let editorContext_ = null;
 

src/svgcanvas/svgcanvas.js

@@ -2701,7 +2701,7 @@ class SvgCanvas {
 * @returns {module:svgcanvas.PrivateMethods}
 */
     this.getPrivateMethods = function () {
-      const obj = {
+      return {
         addCommandToHistory,
         BatchCommand,
         ChangeElementCommand,
@@ -2731,7 +2731,6 @@ class SvgCanvas {
         transformPoint,
         walkTree
       };
-      return obj;
     };
   } // End constructor
 } // End class