Add more tests for svgtransformlist.js. Move from browser-sniffing to feature detection for SVGTransformList.

git-svn-id: http://svg-edit.googlecode.com/svn/trunk@1858 eee81c28-f429-11dd-99c0-75d572ba1ddd

editor/browsersupport.js

@@ -22,6 +22,7 @@ if (!svgedit.browsersupport) {
 
 var svgns = 'http://www.w3.org/2000/svg';
 var userAgent = navigator.userAgent;
+var svg = document.createElementNS(svgns, 'svg');
 
 // Note: Browser sniffing should only be used if no other detection method is possible
 var isOpera_ = !!window.opera;
@@ -34,7 +35,7 @@ svgedit.browsersupport.isGecko = function() { return isGecko_; }
 
 // segList functions (for FF1.5 and 2.0)
 function supportPathReplaceItem() {
-	var path = document.createElementNS(svgns,'path');
+	var path = document.createElementNS(svgns, 'path');
 	path.setAttribute('d','M0,0 10,10');
 	var seglist = path.pathSegList;
 	var seg = path.createSVGPathSegLinetoAbs(5,5);
@@ -80,7 +81,7 @@ function supportEditableText() {
 
 function supportGoodDecimals() {
 	// Correct decimals on clone attributes (Opera < 10.5/win/non-en)
-	var rect = document.createElementNS(svgns,'rect');
+	var rect = document.createElementNS(svgns, 'rect');
 	rect.setAttribute('x',.1);
 	var crect = rect.cloneNode(false);
 	var retValue = (crect.getAttribute('x').indexOf(',') == -1);
@@ -92,16 +93,26 @@ function supportGoodDecimals() {
 }
 
 function supportNonScalingStroke() {
-	var rect = document.createElementNS(svgns,'rect');
+	var rect = document.createElementNS(svgns, 'rect');
 	rect.setAttribute('style','vector-effect:non-scaling-stroke');
 	return rect.style.vectorEffect === 'non-scaling-stroke';
 }
 
+function supportNativeSVGTransformLists() {
+	var rect = document.createElementNS(svgns, 'rect');
+	var rxform = rect.transform.baseVal;
+	
+	var t1 = svg.createSVGTransform();
+	rxform.appendItem(t1);
+	return rxform.getItem(0) == t1;
+}
+
 svgedit.browsersupport.pathReplaceItem = supportPathReplaceItem();
 svgedit.browsersupport.pathInsertItemBefore = supportPathInsertItemBefore();
 svgedit.browsersupport.textCharPos = supportTextCharPos();
 svgedit.browsersupport.editableText = supportEditableText();
 svgedit.browsersupport.goodDecimals = supportGoodDecimals();
 svgedit.browsersupport.nonScalingStroke = supportNonScalingStroke();
+svgedit.browsersupport.nativeTransformLists = supportNativeSVGTransformLists();
 
 })();

editor/svg-editor.html

@@ -10,8 +10,8 @@
 <link rel="stylesheet" href="svg-editor.css" type="text/css"/>
 <link rel="stylesheet" href="spinbtn/JQuerySpinBtn.css" type="text/css"/>
 <!-- Development version of script tags: -->
-<!-- <script type="text/javascript" src="jquery.js"></script> -->
-<script type="text/javascript" src="http://ajax.googleapis.com/ajax/libs/jquery/1.4/jquery.js"></script>
+<script type="text/javascript" src="jquery.js"></script>
+<!--script type="text/javascript" src="http://ajax.googleapis.com/ajax/libs/jquery/1.4/jquery.js"></script-->
 <script type="text/javascript" src="js-hotkeys/jquery.hotkeys.min.js"></script>
 <script type="text/javascript" src="jgraduate/jquery.jgraduate.js"></script>
 <script type="text/javascript" src="svgicons/jquery.svgicons.js"></script>

editor/svgtransformlist.js

@@ -135,21 +135,23 @@ svgedit.transformlist.SVGTransformList = function(elem) {
 		}
 	};
 	this._removeFromOtherLists = function(item) {
-		// Check if this transform is already in a transformlist, and
-		// remove it if so.
-		var found = false;
-		for (var id in listMap_) {
-			var tl = listMap_[id];
-			for (var i = 0, len = tl._xforms.length; i < len; ++i) {
-				if(tl._xforms[i] == item) {
-					found = true;
-					tl.removeItem(i);
+		if (item) {
+			// Check if this transform is already in a transformlist, and
+			// remove it if so.
+			var found = false;
+			for (var id in listMap_) {
+				var tl = listMap_[id];
+				for (var i = 0, len = tl._xforms.length; i < len; ++i) {
+					if(tl._xforms[i] == item) {
+						found = true;
+						tl.removeItem(i);
+						break;
+					}
+				}
+				if (found) {
 					break;
 				}
 			}
-			if (found) {
-				break;
-			}
 		}
 	};
 	
@@ -169,7 +171,7 @@ svgedit.transformlist.SVGTransformList = function(elem) {
 		if (index < this.numberOfItems && index >= 0) {
 			return this._xforms[index];
 		}
-		return null;
+		throw {code: 1}; // DOMException with code=INDEX_SIZE_ERR
 	};
 	
 	this.insertItemBefore = function(newItem, index) {
@@ -210,7 +212,6 @@ svgedit.transformlist.SVGTransformList = function(elem) {
 	};
 	
 	this.removeItem = function(index) {
-		var retValue = null;
 		if (index < this.numberOfItems && index >= 0) {
 			var retValue = this._xforms[index];
 			var newxforms = new Array(this.numberOfItems - 1);
@@ -223,8 +224,10 @@ svgedit.transformlist.SVGTransformList = function(elem) {
 			this.numberOfItems--;
 			this._xforms = newxforms;
 			this._list._update();
+			return retValue;
+		} else {
+			throw {code: 1}; // DOMException with code=INDEX_SIZE_ERR
 		}
-		return retValue;
 	};
 	
 	this.appendItem = function(newItem) {
@@ -258,7 +261,7 @@ svgedit.transformlist.removeElementFromListMap = function(elem) {
 // Parameters:
 // elem - DOM element to get a transformlist from
 svgedit.transformlist.getTransformList = function(elem) {
-	if (svgedit.browsersupport.isWebkit()) {
+	if (!svgedit.browsersupport.nativeTransformLists) {
 		var id = elem.id;
 		if(!id) {
 			// Get unique ID for temporary element