056f4f197c
- Enhancement (svgIcons): Fix JSDoc param def; add alt options - Accessibility: Begin work, add aria-label to some buttons and form controls; add role=main; <img alt>; <iframe title> - i18n: Add lang attribute - Refactoring: lbs, simplify i18nized element retrieval call - Docs: Some JSDoc descriptions, JSDoc spacing, fix svgIcons param def; add todo - Testing: Avoid reporting meta-viewport (have own zooming controls and difficult to fix)
Brett Zamir
2019-04-03 12:49:48 +08:00
69ea647286
- Fix: Droplets for gradient pickers can now be double-clicked in other browsers in addition to Firefox such as Chrome to allow change of color (fixes#181) (@ajinkyas); may be different between the browsers as a result of <https://github.com/w3c/uievents/issues/141> - Builds: Update
Brett Zamir
2019-04-03 11:31:06 +08:00
0171e177cb
- Linting (LGTM): Update to suppress current LGTM warning
Brett Zamir
2019-04-02 17:51:24 +08:00
9bab917623
- Fix/Refactoring: Avoid missing item in loop, assuming it is possible and at least preventing lgtm warnings (lgtm.com-inspired)
Brett Zamir
2019-04-02 11:34:35 +08:00
1ae6e91bb0
- Linting (ESLint): Update polyfills to new compat rules of eslint-config-ash-nazg and adhere to new rules (prefer for-of (or array methods) to for, catch preferred includes to indexOf); avoid no-zero-fractions rule for now - npm: Update devDeps (removing one unneeded)
Brett Zamir
2019-03-31 17:39:19 +08:00
6d9130b1fb
- Refactoring: Make dialog OK button retrievable locale-independently (for testing) - Testing: Avoid testing being locale-dependent; approve storage (and set locale to English) before each test
Brett Zamir
2019-03-16 19:29:14 +08:00
d1f09a19ad
- Testing: Save locale before testing and restore at end
Brett Zamir
2019-03-16 19:11:07 +08:00
2631a21607fix#334 JS error when changing language
cuixiping
2019-03-16 18:33:42 +08:00
dade2a7b37
- Linting (ESLint): Apply coding standards - Testing (Refactoring): Abstract out to helper file functions for approving local storage and opening the main menu - Docs (CHANGES): Update - npm: Update devDeps; update nested deps for security audit
Brett Zamir
2019-03-16 12:30:23 +08:00
5691b7b1e7
add TestCafe UI test
cuixiping
2019-03-15 16:38:33 +08:00
69a5d03e42
Add russian translation to some strings
Александр
2018-12-07 11:34:21 +04:00
cf476ed8ea
- l10n: Add zh-CN dist files - Linting (ESLint): Add back no-console; while useful for debugging, could flag incomplete code (and was breaking at reporting of unused directives) - Docs (CHANGES): Add changes and apply more formal style - Build: Rebuild with updated Babel/Rollup - npm: Update devDeps
Brett Zamir
2018-12-04 14:36:02 +08:00
ba1f0d7f14
- Fix: Adjust side panel width checking based on device zoom (fixes#298)
Brett Zamir
2018-10-30 22:33:29 +08:00
b0fad3d765
- Fix (regression): Fix storage namespace; update build files to get regression fix applied
Brett Zamir
2018-11-16 13:33:13 +08:00
c42791b2b2
- Fix (regression): Arg names not being passed on properly for addExtension
Brett Zamir
2018-11-16 13:02:14 +08:00
2e5c7557a9
- Breaking change: loadSvgString now returns a Promise rather than accepting a callback - Breaking change: Treat callbacks to editor.ready as Promises, only resolving after all resolve - Breaking change: Make editor.runCallbacks return a Promise which resolves upon all callbacks resolving - Breaking change: Require npx (used with babel-node) to allow Node files for HTML building and JSDoc type checking to be expressed as ESM. - Breaking change: addExtension now throws upon a repeated attempt to add an already-added extension - Breaking change (storage preference cookies): Namespace the cookie as "svgeditstore" instead of just "store" - Breaking change (API): Remove svgCanvas.rasterExport fourth (callback) argument, collapsing fifth (options) to fourth - Breaking change (API): Remove svgCanvas.exportPDF third (callback) argument - Breaking change (API): editor/contextmenu.jsadd now throws instead of giving a console error only upon detecting a bad menuitem or preexisting context menu - Breaking change (API): Remove svgCanvas.embedImage second (callback) argument - Breaking change (API): Make getHelpXML a class instead of instance method of RGBColor - Breaking change (internal API): Refactor dbox (and alert/confirm/process/prompt/select) to avoid a callback argument in favor of return a Promise - Fix: Avoid running in extension langReady multiple times or serially - Enhancement (API): Add svgCanvas.runExtension to run just one extension and add nameFilter callback to runExtensions - Enhancement (API): Supply $ (our wrapped jQuery) to extensions so can use its plugins, e.g., dbox with its alert - Enhancement: Use alert dialog in place of alert in webappfind - Enhancement: editor.ready now returns a Promise resolving when all callbacks have resolved - Enhancement: Allow noAlert option as part of second argument to loadSvgString (and loadFromURL and loadFromDataURI) to avoid UI alert (and trigger promise rejection) - Enhancement: Make dbox as a separate module for alert, prompt, etc. dialogs - Refactoring: Internal PaintBox as class; other misc. tweaks; no bitwise in canvg - Linting (ESLint): Further linting changes (for editor); rename .eslintrc -> .eslintrc.json per recommendation - Optimization: Recompress images (imageoptim-cli updated) - npm: Update devDeps - npm: Bump to 4.0.0
Brett Zamir
2018-11-08 14:48:01 +08:00
7c470e9909
- Linting (ESLint): Stricter rules (or switch to warning) - Breaking internal API change: updateGripCursor moved to be class method of Selector rather than instance method - Breaking internal API change: subpathIsClosed moved to be class method of Path rather than instance method - Refactoring: Reuse utilities base64 encoder for SVG icons plugin - Docs (JSDoc): Fix return of the mouseUp (can also be an object) and mouseDown (may also be a boolean) of pathActions; other JSDoc additions/improvements
Brett Zamir
2018-11-07 14:51:50 +08:00
901c9547fe
TODO: Besides splitting this out from previous commit, should really avoid markdown field in favor of modifying jsdoc to report wherever it lays out "prettyprint"; still probably missing some one-liners; see https://github.com/google/code-prettify; update builds to confirm new stackblur is working; add below to CHANGES; add back for eslint-plugin-jsdoc once merged (though need new version ^3.9.1); move any linting changes to other linting branch - Refactoring (minor): Add favicon to canvas demo - Linting (ESLint Markdown JavaScript): Add eslint-plugin-markdown with slightly loosened config (no-undef and padded-blocks off and no-unused-vars as a warning) - Linting (ESLint JSDoc code comments): Add eslint-plugin-jsdoc and apply to JSDoc code comments - Linting (ESLint): Completely avoid unescaped tabs in files - Docs (Linting): Add linting info file - npm: Rename copy-deps script to copy - Refactoring: Add stackblur-canvas as a dependency and copy it in (until such time as we can do so for canvg)
Brett Zamir
2018-10-31 03:41:22 +08:00
afa5576ed1
TODO: Check out https://github.com/qard/remark-lint-code and https://www.npmjs.com/package/remark-lint-code-eslint ; add below to CHANGES - Docs (JSDocs) Switch to JS-based config file - Leverage syntax highlighting reporting of JSDoc to lint our code (npm version does not seem to reflect that on Github, so we use Github version we need) - Docs (ESLint): Apply most of our ESLint rules (except no-undefined and padded-blocks) to sample code blocks
Brett Zamir
2018-10-31 02:43:45 +08:00
8899680e60
- npm: Actually commit minor version update to avoid vulnerable qunit dependency; also update sinon - npm: Avoid using Github version of JSDoc (used in a branch for layout override testing); do a fresh install of all packages and update package-lock.json accordingly; update qunit dist and openclipart - npm: Bump to 3.2.0
Brett Zamir
2018-11-04 15:38:28 +08:00
8775528c94
- Docs (CHANGES): Add main heading - npm: Update devDeps (including Jamilih copied into dist files as well as an updated qunit which resolves some security vulnerabilities
Brett Zamir
2018-11-04 15:14:53 +08:00
f78fb05454
- Docs (JSDocs regression): Use nested array format recognized by both ESLint and JSDoc
Brett Zamir
2018-10-31 02:13:09 +08:00
aef7b095ef
- Refactoring: Avoid unnecessary addEventListener false; change internal jPicker function to class (used with new) - Linting (ESLint): Add valid-jsdoc rule and make fixes; but turn off for now due to <https://github.com/eslint/eslint/issues/11036> and <https://github.com/eslint/eslint/issues/11037> - Docs (JSDoc): Add some Markdown for variables, line breaks; tighten checks for overly generic types (though allow for .Function as in jQuery.Function) and avoid one previously missed instance
Brett Zamir
2018-10-30 23:25:20 +08:00
9b9c900ede
- Linting (ESLint compat): Add eslint-plugin-compat to get browser support warnings - Docs (README): Indicate minimal polyfills needed for older browsers (IE <= 11, IE Mobile, Opera Mini, Blackberry Browser <= 10, Android Browser 4.4.3-4.4.4) - npm: Update devDeps
Brett Zamir
2018-10-29 08:46:34 +08:00
89515b7e1e
- Docs: For clarity, rename grep-jsdoc.js to jsdoc-check-overly-generic-types.js - Docs: Move GenericCallback to typedefs.js for possible reuse - npm: Update "grep-doc" to "types-doc" for greater clarity
Brett Zamir
2018-10-25 10:09:32 +08:00
9a9f5b6a18
- npm: Per convention, switch Node-based (headless browser) testing script to npm test and change the browser tests to "browser-test"
Brett Zamir
2018-10-24 15:24:08 +08:00
283ef0b521
- Fix: Have export handler, if triggered, always open a window even if no window name was given (needed in Chrome to avoid opening an extra window) - Fix (Embedded editor regression): Ensure event handlers are added even if document cannot be directly modified - Enhancement: Add opts object to rasterExport with avoidEvent property to avoid calling the exported event - Docs (CHANGES): Update - Docs (README): Deemphasize unstable embedded editor fixes
Brett Zamir
2018-10-24 14:45:52 +08:00
07f59ba01a
- Refactoring: Reorder path config to group (non-modular-dependent) image paths together (and correct code comment) - Docs: CHANGES clarifications/fixes - Docs: Migrations documents section - Docs: Add code comment re: use of extIconsPath in Mathjax - Docs: Add JSDoc indicate @this for ExtensionInitResponse#callback - Build: Update build files - npm: Bump to 3.1.0
Brett Zamir
2018-10-23 18:35:49 +08:00
9d454d79fd
- Refactoring: Rename no modules redirect file to begin with "redirect" as with other redirect
Brett Zamir
2018-10-24 11:03:26 +08:00
4a0889c7e5
- Enhancement: For anyone visiting the ES6 modules entrance file without ESM support, redirect to non-modular vesion - Build: Add comment not to edit xdomain editor directly
Brett Zamir
2018-10-24 10:55:46 +08:00
25f02d99f2
- Refactoring: Display inline styles within a template for readability (until we may refactor as class swapping) - Refactoring: Line breaks
Brett Zamir
2018-10-24 09:44:43 +08:00
a714c122d3
- Fix (Embedded editor): (Though embedding cross-origin iframes apparently only working now in Chrome if same origin or if https?--at least not localhost of different ports), PDF export has been fixed (we download the PDF to workaround data URI limitations in Chrome) - Fix (Embedded editor): Avoid using same origin shortcut if there is no global available to use (e.g., if using the modular editor) - Fix (Embedded editor): Add events only after load is complete and svgCanvas is available; also log blocked error objects - Enhancement: For PDF export, switch Chrome by default to "save" outputType - Docs (JSdoc): Denote optional arguments
Brett Zamir
2018-10-23 22:24:09 +08:00
5b4dae0d30
- Docs: CHANGES clarifications - Docs: More info on importLocale for extensions - Refactoring: Better type-checking on canvasRGBA_ (but set correctly by default anyways) - Build: Remove unused Makefile
Brett Zamir
2018-10-23 18:35:49 +08:00
2835ec11b6
- Refactoring: Avoid redundant use of *AttributeNS methods with null value; just use *Attribute methods without namespace
Brett Zamir
2018-10-23 18:13:36 +08:00
f4bbd34d34
- Fix: Revert fix to have extension mouseup events run on "zoom" and "select" modes (#159); breaks polygon selection - npm: Bump to 3.0.1
Brett Zamir
2018-10-22 23:43:59 +08:00
2cecbac24a
- Fix (jgraduate->jpicker): Actually fix issue with color val check when no other proper results (equal to "all"); prior fix had not covered original intention - Docs: Clean-up and fixes in CHANGES
Brett Zamir
2018-10-22 23:13:04 +08:00
052a2c4571
- Docs: Add CHANGES info for npm 3.0.0-alpha.1 (i.e., changes between 2.8.1 and alpha.2) - Docs: Add "optimization" and "localization" as commit prefixes
Brett Zamir
2018-10-22 10:58:39 +08:00
5e7a90b809
- Docs: More info on unpkg.com and how releases share URLs only, not downloads (at least for now)
Brett Zamir
2018-10-21 19:31:46 +08:00
d13f99bb5e
- Breaking change: Remove storagePromptClosed state boolean in favor of storagePromptState; used by ext-storage.js - Fix (regression): Ensure storage dialog will not be blocked because of canvas updating done for sake of centering background - Fix (extensions): Ensure langReady changes are available by time prefs dialog is closed and that its changes have occurred by time extensions have first loaded (setLang now returns a Promise rather than undefined as it waits for extension's langReady to resolve); this is also useful with ext-storage.js so we know that extensions_loaded (which conditionally updates the canvas based on storagePromptState) has seen langReady and the storage extension hasn't set a storagePromptState of "waiting"
Brett Zamir
2018-10-21 18:33:23 +08:00
c37e60fd87
- Fix: Centering of canvas wasn't being set at proper time; fixes#272 - Refactoring: Avoid unneeded internal IIFEs; simplify w/h formula
Brett Zamir
2018-10-21 01:13:44 +08:00
5d9da2d56e
- Breaking change: For checkbox for persisting choice of initial use storage approval in storage extension dialog, turn on by default for convenience of most users (must still hit "ok" and users can still turn off the checkbox)
Brett Zamir
2018-10-20 23:38:47 +08:00
644af63e4a
- .gitignore/.npmignore: Allow for ignore folder for notes; add old build-related/remote linting files to npmignore
Brett Zamir
2018-10-20 22:32:49 +08:00
fb9eb80798
- Fix (regression): Extension locale loading for non-English locales - Fix: Allow language to be properly set back to a different locale and retaining preference (and ensure language changes are available before dialog closed) - Refactoring: array extra/spread operator - npm: Update devDep (sinon-test)
Brett Zamir
2018-10-20 22:04:39 +08:00
8024304a96
- Fix: Map extension click events to "mousedown" so they can be received on touch devices (since touch.js changes touchstart to mousedown) (@ClemArt); closes#168 - Fix: Ensure extension mouseup events run on "zoom" and "select" modes (@iuyiuy); closes#159
Brett Zamir
2018-10-19 20:38:18 +08:00
Brett Zamir