- Breaking change: Treat callbacks to `editor.ready` as Promises, only resolving after all resolve - Breaking change: Make `editor.runCallbacks` return a `Promise` which resolves upon all callbacks resolving - Breaking change: Require `npx` (used with `babel-node`) to allow Node files for HTML building and JSDoc type checking to be expressed as ESM. - Breaking change: `addExtension` now throws upon a repeated attempt to add an already-added extension - Breaking change (storage preference cookies): Namespace the cookie as "svgeditstore" instead of just "store" - Breaking change (API): Remove `svgCanvas.rasterExport` fourth (callback) argument, collapsing fifth (options) to fourth - Breaking change (API): Remove `svgCanvas.exportPDF` third (callback) argument - Breaking change (API): `editor/contextmenu.js` `add` now throws instead of giving a console error only upon detecting a bad menuitem or preexisting context menu - Breaking change (API): Remove `svgCanvas.embedImage` second (callback) argument - Breaking change (API): Make `getHelpXML` a class instead of instance method of `RGBColor` - Breaking change (internal API): Refactor `dbox` (and `alert`/`confirm`/`process`/`prompt`/`select`) to avoid a callback argument in favor of return a Promise - Fix: Avoid running in extension `langReady` multiple times or serially - Enhancement (API): Add svgCanvas.runExtension to run just one extension and add `nameFilter` callback to `runExtensions` - Enhancement (API): Supply `$` (our wrapped jQuery) to extensions so can use its plugins, e.g., dbox with its `alert` - Enhancement: Use alert dialog in place of `alert` in webappfind - Enhancement: `editor.ready` now returns a Promise resolving when all callbacks have resolved - Enhancement: Allow `noAlert` option as part of second argument to `loadSvgString` (and `loadFromURL` and `loadFromDataURI`) to avoid UI alert (and trigger promise rejection) - Enhancement: Make `dbox` as a separate module for alert, prompt, etc. dialogs - Refactoring: Internal `PaintBox` as class; other misc. tweaks; no bitwise in canvg - Linting (ESLint): Further linting changes (for editor); rename `.eslintrc` -> `.eslintrc.json` per recommendation - Optimization: Recompress images (imageoptim-cli updated) - npm: Update devDeps - npm: Bump to 4.0.0
74 lines
2.2 KiB
JavaScript
74 lines
2.2 KiB
JavaScript
/* eslint-env qunit */
|
|
import * as contextmenu from '../editor/contextmenu.js';
|
|
|
|
// log function
|
|
QUnit.log((details) => {
|
|
if (window.console && window.console.log) {
|
|
window.console.log(details.result + ' :: ' + details.message);
|
|
}
|
|
});
|
|
|
|
/**
|
|
* Tear down tests, resetting custom menus.
|
|
* @returns {undefined}
|
|
*/
|
|
function tearDown () {
|
|
contextmenu.resetCustomMenus();
|
|
}
|
|
|
|
QUnit.module('svgedit.contextmenu');
|
|
|
|
QUnit.test('Test svgedit.contextmenu package', function (assert) {
|
|
assert.expect(4);
|
|
|
|
assert.ok(contextmenu, 'contextmenu registered correctly');
|
|
assert.ok(contextmenu.add, 'add registered correctly');
|
|
assert.ok(contextmenu.hasCustomHandler, 'contextmenu hasCustomHandler registered correctly');
|
|
assert.ok(contextmenu.getCustomHandler, 'contextmenu getCustomHandler registered correctly');
|
|
});
|
|
|
|
QUnit.test('Test svgedit.contextmenu does not add invalid menu item', function (assert) {
|
|
assert.expect(3);
|
|
|
|
assert.throws(
|
|
() => contextmenu.add({id: 'justanid'}),
|
|
'menu item with just an id is invalid'
|
|
);
|
|
|
|
assert.throws(
|
|
() => contextmenu.add({id: 'idandlabel', label: 'anicelabel'}),
|
|
'menu item with just an id and label is invalid'
|
|
);
|
|
|
|
assert.throws(
|
|
() => contextmenu.add({id: 'idandlabel', label: 'anicelabel', action: 'notafunction'}),
|
|
'menu item with action that is not a function is invalid'
|
|
);
|
|
});
|
|
|
|
QUnit.test('Test svgedit.contextmenu adds valid menu item', function (assert) {
|
|
assert.expect(2);
|
|
|
|
const validItem = {id: 'valid', label: 'anicelabel', action () { console.log('testing'); }};
|
|
contextmenu.add(validItem);
|
|
|
|
assert.ok(contextmenu.hasCustomHandler('valid'), 'Valid menu item is added.');
|
|
assert.equal(contextmenu.getCustomHandler('valid'), validItem.action, 'Valid menu action is added.');
|
|
tearDown();
|
|
});
|
|
|
|
QUnit.test('Test svgedit.contextmenu rejects valid duplicate menu item id', function (assert) {
|
|
assert.expect(1);
|
|
|
|
const validItem1 = {id: 'valid', label: 'anicelabel', action () { console.log('testing'); }};
|
|
const validItem2 = {id: 'valid', label: 'anicelabel', action () { console.log('testingtwice'); }};
|
|
contextmenu.add(validItem1);
|
|
|
|
assert.throws(
|
|
() => contextmenu.add(validItem2),
|
|
'duplicate menu item is rejected.'
|
|
);
|
|
|
|
tearDown();
|
|
});
|