2e5c7557a9
- Breaking change: Treat callbacks to `editor.ready` as Promises, only resolving after all resolve - Breaking change: Make `editor.runCallbacks` return a `Promise` which resolves upon all callbacks resolving - Breaking change: Require `npx` (used with `babel-node`) to allow Node files for HTML building and JSDoc type checking to be expressed as ESM. - Breaking change: `addExtension` now throws upon a repeated attempt to add an already-added extension - Breaking change (storage preference cookies): Namespace the cookie as "svgeditstore" instead of just "store" - Breaking change (API): Remove `svgCanvas.rasterExport` fourth (callback) argument, collapsing fifth (options) to fourth - Breaking change (API): Remove `svgCanvas.exportPDF` third (callback) argument - Breaking change (API): `editor/contextmenu.js` `add` now throws instead of giving a console error only upon detecting a bad menuitem or preexisting context menu - Breaking change (API): Remove `svgCanvas.embedImage` second (callback) argument - Breaking change (API): Make `getHelpXML` a class instead of instance method of `RGBColor` - Breaking change (internal API): Refactor `dbox` (and `alert`/`confirm`/`process`/`prompt`/`select`) to avoid a callback argument in favor of return a Promise - Fix: Avoid running in extension `langReady` multiple times or serially - Enhancement (API): Add svgCanvas.runExtension to run just one extension and add `nameFilter` callback to `runExtensions` - Enhancement (API): Supply `$` (our wrapped jQuery) to extensions so can use its plugins, e.g., dbox with its `alert` - Enhancement: Use alert dialog in place of `alert` in webappfind - Enhancement: `editor.ready` now returns a Promise resolving when all callbacks have resolved - Enhancement: Allow `noAlert` option as part of second argument to `loadSvgString` (and `loadFromURL` and `loadFromDataURI`) to avoid UI alert (and trigger promise rejection) - Enhancement: Make `dbox` as a separate module for alert, prompt, etc. dialogs - Refactoring: Internal `PaintBox` as class; other misc. tweaks; no bitwise in canvg - Linting (ESLint): Further linting changes (for editor); rename `.eslintrc` -> `.eslintrc.json` per recommendation - Optimization: Recompress images (imageoptim-cli updated) - npm: Update devDeps - npm: Bump to 4.0.0
96 lines
2.8 KiB
JavaScript
96 lines
2.8 KiB
JavaScript
/* eslint-env node */
|
|
/**
|
|
* @todo Fork find-in-files to get ignore pattern support
|
|
*/
|
|
import fif from 'find-in-files';
|
|
|
|
(async () => {
|
|
/**
|
|
* @typedef {PlainObject} FileResult
|
|
* @property {string[]} matches
|
|
* @property {Integer} count
|
|
* @property {string[]} line
|
|
*/
|
|
const fileMatchPatterns = ['editor'];
|
|
/**
|
|
* Keys are file name strings
|
|
* @type {Object.<string, FileResult>}
|
|
*/
|
|
let results = await Promise.all(fileMatchPatterns.map((fileMatchPattern) => {
|
|
return fif.find(
|
|
{
|
|
// We grab to the end of the line as the `line` result for `find-in-files`
|
|
// only grabs from the beginning of the file to the end of the match.
|
|
term: `(@[^{\\n]*{[^}\\n]*(\\bobject|\\barray\\b|[^.]function|\\bnumber|\\*)[^}\\n]*}|@.*{} ).*`,
|
|
flags: 'gi'
|
|
},
|
|
fileMatchPattern,
|
|
'([^n]|[^i]n|[^m]in|[^.]min).js$'
|
|
);
|
|
}));
|
|
results = Object.assign(...results);
|
|
let total = 0;
|
|
let output = '';
|
|
Object.entries(results).forEach(([file, res]) => {
|
|
reduceFalseMatches(file, res);
|
|
if (!res.line.length) {
|
|
return;
|
|
}
|
|
output += `\nFound ${res.count} potentially overly generic JSDoc expression${res.count === 1 ? '' : 's'} in file ${file}:\n`;
|
|
res.line.forEach((line) => {
|
|
output += line + '\n';
|
|
});
|
|
total += res.line.length;
|
|
/*
|
|
res.matches.forEach((match) => {
|
|
console.log(match);
|
|
});
|
|
*/
|
|
});
|
|
console.log(`${output}\nTotal failures found: ${total}.\n`); // eslint-disable-line no-console
|
|
|
|
/**
|
|
* @external FindInFilesResult
|
|
* @type {PlainObject}
|
|
* @property {string[]} matches The matched strings
|
|
* @property {Integer} count The number of matches
|
|
* @property {string[]} line The lines that were matched. The docs mistakenly indicate the property is named `lines`; see {@link https://github.com/kaesetoast/find-in-files/pull/19}.
|
|
*/
|
|
|
|
/**
|
|
* Eliminates known false matches against overly generic types.
|
|
* @param {string} file
|
|
* @param {external:FindInFilesResult} res
|
|
* @returns {undefined}
|
|
*/
|
|
function reduceFalseMatches (file, res) {
|
|
switch (file) {
|
|
case 'editor/external/jamilih/jml-es.js':
|
|
case 'editor/xdomain-svgedit-config-iife.js': // Ignore
|
|
res.line = [];
|
|
break;
|
|
case 'editor/embedapi.js':
|
|
res.line = res.line.filter((line) => {
|
|
return ![
|
|
'* @param {...*} args Signature dependent on the function'
|
|
].includes(line);
|
|
});
|
|
break;
|
|
case 'editor/typedefs.js':
|
|
res.line = res.line.filter((line) => {
|
|
return ![
|
|
'* @typedef {number} Float',
|
|
'* @typedef {Object} ArbitraryObject',
|
|
'* @typedef {Object} ArbitraryModule',
|
|
'* @typedef {Array} GenericArray',
|
|
'* @typedef {*} Any',
|
|
'* @param {...*} args Signature dependent on the function',
|
|
'* @returns {*} Return dependent on the function'
|
|
].includes(line);
|
|
});
|
|
break;
|
|
}
|
|
res.count = res.line.length;
|
|
}
|
|
})();
|