github/Discord.Net
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix Slash Command Localizations lost after AddCommandsToGuildAsync and deleteMissing = false (#2758)

Browse Source 
fetch localizations when adding commands with `deleteMissing` = `false`

fixes #2757
This commit is contained in:
Markus Oppmann
2023-11-18 21:51:54 +01:00
committed by GitHub
parent ab3b30dee4
commit 8d5022acb8
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/Discord.Net.Interactions/InteractionService.cs
View File

@@ -392,7 +392,7 @@ namespace Discord.Interactions
if (!deleteMissing) if (!deleteMissing)
{ {
var existing = await RestClient.GetGuildApplicationCommands(guildId).ConfigureAwait(false); var existing = await RestClient.GetGuildApplicationCommands(guildId, true).ConfigureAwait(false);
var missing = existing.Where(x => !props.Any(y => y.Name.IsSpecified && y.Name.Value == x.Name)); var missing = existing.Where(x => !props.Any(y => y.Name.IsSpecified && y.Name.Value == x.Name));
props.AddRange(missing.Select(x => x.ToApplicationCommandProps())); props.AddRange(missing.Select(x => x.ToApplicationCommandProps()));
} }
@@ -416,7 +416,7 @@ namespace Discord.Interactions
if (!deleteMissing) if (!deleteMissing)
{ {
var existing = await RestClient.GetGlobalApplicationCommands().ConfigureAwait(false); var existing = await RestClient.GetGlobalApplicationCommands(true).ConfigureAwait(false);
var missing = existing.Where(x => !props.Any(y => y.Name.IsSpecified && y.Name.Value == x.Name)); var missing = existing.Where(x => !props.Any(y => y.Name.IsSpecified && y.Name.Value == x.Name));
props.AddRange(missing.Select(x => x.ToApplicationCommandProps())); props.AddRange(missing.Select(x => x.ToApplicationCommandProps()));
} }
@@ -481,7 +481,7 @@ namespace Discord.Interactions
if (!deleteMissing) if (!deleteMissing)
{ {
var existing = await RestClient.GetGuildApplicationCommands(guildId).ConfigureAwait(false); var existing = await RestClient.GetGuildApplicationCommands(guildId, true).ConfigureAwait(false);
var missing = existing.Where(x => !props.Any(y => y.Name.IsSpecified && y.Name.Value == x.Name)); var missing = existing.Where(x => !props.Any(y => y.Name.IsSpecified && y.Name.Value == x.Name));
props.AddRange(missing.Select(x => x.ToApplicationCommandProps())); props.AddRange(missing.Select(x => x.ToApplicationCommandProps()));
} }
@@ -523,7 +523,7 @@ namespace Discord.Interactions
if (!deleteMissing) if (!deleteMissing)
{ {
var existing = await RestClient.GetGuildApplicationCommands(guildId).ConfigureAwait(false); var existing = await RestClient.GetGuildApplicationCommands(guildId, true).ConfigureAwait(false);
var missing = existing.Where(x => !props.Any(y => y.Name.IsSpecified && y.Name.Value == x.Name)); var missing = existing.Where(x => !props.Any(y => y.Name.IsSpecified && y.Name.Value == x.Name));
props.AddRange(missing.Select(x => x.ToApplicationCommandProps())); props.AddRange(missing.Select(x => x.ToApplicationCommandProps()));
} }
@@ -547,7 +547,7 @@ namespace Discord.Interactions
if (!deleteMissing) if (!deleteMissing)
{ {
var existing = await RestClient.GetGlobalApplicationCommands().ConfigureAwait(false); var existing = await RestClient.GetGlobalApplicationCommands(true).ConfigureAwait(false);
var missing = existing.Where(x => !props.Any(y => y.Name.IsSpecified && y.Name.Value == x.Name)); var missing = existing.Where(x => !props.Any(y => y.Name.IsSpecified && y.Name.Value == x.Name));
props.AddRange(missing.Select(x => x.ToApplicationCommandProps())); props.AddRange(missing.Select(x => x.ToApplicationCommandProps()));
} }
@@ -590,7 +590,7 @@ namespace Discord.Interactions
if (!deleteMissing) if (!deleteMissing)
{ {
var existing = await RestClient.GetGlobalApplicationCommands().ConfigureAwait(false); var existing = await RestClient.GetGlobalApplicationCommands(true).ConfigureAwait(false);
var missing = existing.Where(x => !props.Any(y => y.Name.IsSpecified && y.Name.Value == x.Name)); var missing = existing.Where(x => !props.Any(y => y.Name.IsSpecified && y.Name.Value == x.Name));
props.AddRange(missing.Select(x => x.ToApplicationCommandProps())); props.AddRange(missing.Select(x => x.ToApplicationCommandProps()));
} }