Tweaks to audio docs (#867)

* Tweaks to audio docs

* Make it more obvious that -1 means infinity

docs/guides/getting_started/samples/intro/structure.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Reflection;
+using System.Threading;
 using System.Threading.Tasks;
 using Microsoft.Extensions.DependencyInjection;
 using Discord;
@@ -88,7 +89,7 @@ class Program
         await _client.StartAsync();
 
         // Wait infinitely so your bot actually stays connected.
-        await Task.Delay(-1);
+        await Task.Delay(Timeout.Infinite);
     }
 
     private IServiceProvider _services;

docs/guides/voice/samples/audio_create_ffmpeg.cs

@@ -1,11 +1,10 @@
 private Process CreateStream(string path)
 {
-    var ffmpeg = new ProcessStartInfo
+    return Process.Start(new ProcessStartInfo
     {
         FileName = "ffmpeg",
-        Arguments = $"-i {path} -ac 2 -f s16le -ar 48000 pipe:1",
+        Arguments = $"-hide_banner -loglevel panic -i \"{path}\" -ac 2 -f s16le -ar 48000 pipe:1",
         UseShellExecute = false,
         RedirectStandardOutput = true,
-    };
-    return Process.Start(ffmpeg);
-}
+    });
+}

docs/guides/voice/samples/audio_ffmpeg.cs

@@ -1,9 +1,11 @@
 private async Task SendAsync(IAudioClient client, string path)
 {
     // Create FFmpeg using the previous example
-    var ffmpeg = CreateStream(path);
-    var output = ffmpeg.StandardOutput.BaseStream;
-    var discord = client.CreatePCMStream(AudioApplication.Mixed);
-    await output.CopyToAsync(discord);
-    await discord.FlushAsync();
+    using (var ffmpeg = CreateStream(path))
+    using (var output = ffmpeg.StandardOutput.BaseStream)
+    using (var discord = client.CreatePCMStream(AudioApplication.Mixed))
+    {
+        try { await output.CopyToAsync(discord); }
+        finally { await discord.FlushAsync(); }
+    }
 }

docs/guides/voice/samples/joining_audio.cs

@@ -7,4 +7,4 @@ public async Task JoinChannel(IVoiceChannel channel = null)
 
     // For the next step with transmitting audio, you would want to pass this Audio Client in to a service.
     var audioClient = await channel.ConnectAsync();
-}
+}