github/SharpIDE
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

update project diagnostics for active document immediately

Browse Source
This commit is contained in:
Matt Parker
2025-11-25 00:22:57 +10:00
parent 6ad66d0368
commit a7157e2cf1
3 changed files with 28 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/SharpIDE.Application/Features/Analysis/RoslynAnalysis.cs
View File

@@ -301,15 +301,27 @@ public class RoslynAnalysis(ILogger<RoslynAnalysis> logger, BuildService buildSe
// Performance improvements of ~15% have been observed with a large solution (100+ projects) by parallelizing this with Task.WhenAll, however it seems much heavier (14700K crashes sometimes 😅) so re-evaluate later
foreach (var project in _sharpIdeSolutionModel!.AllProjects)
{
var projectDiagnostics = await GetProjectDiagnostics(project, cancellationToken);
// TODO: only add and remove diffs
project.Diagnostics.RemoveRange(project.Diagnostics);
project.Diagnostics.AddRange(projectDiagnostics);
await UpdateProjectDiagnostics(project, cancellationToken);
}
timer.Stop();
_logger.LogInformation("RoslynAnalysis: Solution diagnostics updated in {ElapsedMilliseconds}ms", timer.ElapsedMilliseconds);
}
public async Task UpdateProjectDiagnostics(SharpIdeProjectModel project, CancellationToken cancellationToken = default)
{
var projectDiagnostics = await GetProjectDiagnostics(project, cancellationToken);
// TODO: only add and remove diffs
project.Diagnostics.RemoveRange(project.Diagnostics);
project.Diagnostics.AddRange(projectDiagnostics);
}
public async Task UpdateProjectDiagnosticsForFile(SharpIdeFile sharpIdeFile, CancellationToken cancellationToken = default)
{
var project = ((IChildSharpIdeNode) sharpIdeFile).GetNearestProjectNode();
Guard.Against.Null(project);
await UpdateProjectDiagnostics(project, cancellationToken);
}
public async Task<ImmutableArray<SharpIdeDiagnostic>> GetProjectDiagnostics(SharpIdeProjectModel projectModel, CancellationToken cancellationToken = default)
{
using var _ = SharpIdeOtel.Source.StartActivity($"{nameof(RoslynAnalysis)}.{nameof(GetProjectDiagnostics)}");

8
src/SharpIDE.Godot/Features/CodeEditor/SharpIdeCodeEdit.cs
View File

@@ -104,16 +104,22 @@ public partial class SharpIdeCodeEdit : CodeEdit
if (_fileDeleted) return;
GD.Print($"[{_currentFile.Name}] Solution altered, updating project diagnostics for file");
var newCt = _solutionAlteredCancellationTokenSeries.CreateNext();
var hasFocus = this.InvokeAsync(HasFocus);
var documentSyntaxHighlighting = _roslynAnalysis.GetDocumentSyntaxHighlighting(_currentFile, newCt);
var razorSyntaxHighlighting = _roslynAnalysis.GetRazorDocumentSyntaxHighlighting(_currentFile, newCt);
await Task.WhenAll(documentSyntaxHighlighting, razorSyntaxHighlighting).WaitAsync(newCt).ConfigureAwait(ConfigureAwaitOptions.SuppressThrowing);
if (newCt.IsCancellationRequested) return;
var documentDiagnosticsTask = _roslynAnalysis.GetDocumentDiagnostics(_currentFile, newCt);
await this.InvokeAsync(async () => SetSyntaxHighlightingModel(await documentSyntaxHighlighting, await razorSyntaxHighlighting));
await ((Task)documentDiagnosticsTask).ConfigureAwait(ConfigureAwaitOptions.SuppressThrowing);
await documentDiagnosticsTask.AsTask().ConfigureAwait(ConfigureAwaitOptions.SuppressThrowing);
if (newCt.IsCancellationRequested) return;
var documentDiagnostics = await documentDiagnosticsTask;
await this.InvokeAsync(() => SetDiagnostics(documentDiagnostics));
if (await hasFocus)
{
await _roslynAnalysis.UpdateProjectDiagnosticsForFile(_currentFile, newCt).ConfigureAwait(ConfigureAwaitOptions.SuppressThrowing);
if (newCt.IsCancellationRequested) return;
}
}
public enum LineEditOrigin

5
src/SharpIDE.Godot/NodeExtensions.cs
View File

@@ -174,6 +174,11 @@ public static class NodeExtensions
public static class GodotTask
{
extension<T>(Task<T> task)
{
public Task AsTask() => task;
}
extension(Task task)
{
public static async Task GodotRun(Action action)