github/gallery-dl
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[reddit] support video embeds (#8139)

Browse Source
This commit is contained in:
Mike Fährmann
2025-08-29 20:49:11 +02:00
parent 38542a8bba
commit 94c72a71fa
2 changed files with 30 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
gallery_dl/extractor/reddit.py
View File

@@ -84,6 +84,12 @@ class RedditExtractor(Extractor):
text.nameext_from_url(url, submission)
yield Message.Url, url, submission
elif embeds and "media_metadata" in media:
for embed in self._extract_embed(submission):
submission["num"] += 1
text.nameext_from_url(embed, submission)
yield Message.Url, embed, submission
elif media["is_video"]:
if videos:
text.nameext_from_url(url, submission)
@@ -199,19 +205,26 @@ class RedditExtractor(Extractor):
return
for mid, data in meta.items():
if data["status"] != "valid" or "s" not in data:
if data["status"] != "valid":
self.log.warning(
"embed %s: skipping item %s (status: %s)",
submission["id"], mid, data.get("status"))
continue
src = data["s"]
if url := src.get("u") or src.get("gif") or src.get("mp4"):
yield url.partition("?")[0].replace("/preview.", "/i.", 1)
else:
self.log.error(
"embed %s: unable to fetch download URL for item %s",
submission["id"], mid)
self.log.debug(src)
if src := data.get("s"):
if url := src.get("u") or src.get("gif") or src.get("mp4"):
yield url.partition("?")[0].replace("/preview.", "/i.", 1)
else:
self.log.error(
"embed %s: unable to fetch download URL for item %s",
submission["id"], mid)
self.log.debug(src)
elif url := data.get("dashUrl"):
submission["_ytdl_manifest"] = "dash"
yield f"ytdl:{url}"
elif url := data.get("hlsUrl"):
submission["_ytdl_manifest"] = "hls"
yield f"ytdl:{url}"
def _extract_video_ytdl(self, submission):
return "https://www.reddit.com" + submission["permalink"]

8
test/results/reddit.py
View File

@@ -267,6 +267,14 @@ __tests__ = (
"#class" : reddit.RedditSubmissionExtractor,
},
{
"#url" : "https://www.reddit.com/user/-frogchamp-/comments/1n260wh/osc_art_request_timelapsespeed_draw_so_far_flash/",
"#comment" : "video embed (#8139)",
"#class" : reddit.RedditSubmissionExtractor,
"#options" : {"api": "rest"},
"#results" : "ytdl:https://v.redd.it/link/1n260wh/asset/8q50b220tplf1/DASHPlaylist.mpd?a=1759085227%2CYTU2NGJjNTlmNjBlOGE2NWUwYWI0MjRjZDYzZjllZjk4Nzc3Y2Y4Nzc1NDMzOTBkYTNkOWFjOGMzZjUzZDAzMQ%3D%3D&v=1&f=sd",
},
{
"#url" : "https://i.redd.it/upjtjcx2npzz.jpg",
"#category": ("", "reddit", "image"),