github/gallery-dl
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

improve attribute access in DownloadJob.handle_url()

Browse Source 
Storing a value in a local variable an accessing it that way is faster
than going through 'self' if it is accessed more than once.
This commit is contained in:
Mike Fährmann
2019-07-13 21:42:07 +02:00
parent 56c7a66a4a
commit fe7805de7c
1 changed files with 19 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
gallery_dl/job.py
View File

@@ -190,14 +190,18 @@ class DownloadJob(Job):
def handle_url(self, url, keywords, fallback=None):
"""Download the resource specified in 'url'"""
postprocessors = self.postprocessors
pathfmt = self.pathfmt
archive = self.archive
# prepare download
self.pathfmt.set_keywords(keywords)
pathfmt.set_keywords(keywords)
if self.postprocessors:
for pp in self.postprocessors:
pp.prepare(self.pathfmt)
if postprocessors:
for pp in postprocessors:
pp.prepare(pathfmt)
if self.pathfmt.exists(self.archive):
if pathfmt.exists(archive):
self.handle_skip()
return
@@ -214,24 +218,24 @@ class DownloadJob(Job):
break
else:
# download failed
self.log.error(
"Failed to download %s", self.pathfmt.filename or url)
self.log.error("Failed to download %s",
pathfmt.filename or url)
return
if not self.pathfmt.temppath:
if not pathfmt.temppath:
self.handle_skip()
return
# run post processors
if self.postprocessors:
for pp in self.postprocessors:
pp.run(self.pathfmt)
if postprocessors:
for pp in postprocessors:
pp.run(pathfmt)
# download succeeded
self.pathfmt.finalize()
self.out.success(self.pathfmt.path, 0)
if self.archive:
self.archive.add(keywords)
pathfmt.finalize()
self.out.success(pathfmt.path, 0)
if archive:
archive.add(keywords)
self._skipcnt = 0
def handle_urllist(self, urls, keywords):