github/portmaster
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #252 from safing/fix/dns-mixing

Browse Source 
Stop randomizing dns answer records
This commit is contained in:
Daniel
2021-02-11 16:02:31 +01:00
committed by GitHub
parent 087b8de216 fa595a53d5
commit 219e6ba1a2
1 changed files with 2 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
resolver/rrcache.go
View File

@@ -3,7 +3,6 @@ package resolver
import (
"context"
"fmt"
"math/rand"
"net"
"time"
@@ -286,7 +285,8 @@ func (rrCache *RRCache) ReplaceAnswerNames(fqdn string) {
}
}
// ReplyWithDNS creates a new reply to the given query with the data from the RRCache, and additional informational records.
// ReplyWithDNS creates a new reply to the given query with the data from the
// RRCache, and additional informational records.
func (rrCache *RRCache) ReplyWithDNS(ctx context.Context, request *dns.Msg) *dns.Msg {
// reply to query
reply := new(dns.Msg)
@@ -295,13 +295,6 @@ func (rrCache *RRCache) ReplyWithDNS(ctx context.Context, request *dns.Msg) *dns
reply.Ns = rrCache.Ns
reply.Extra = rrCache.Extra
// Randomize the order of the answer records a little to allow dumb clients
// (who only look at the first record) to reliably connect.
for i := range reply.Answer {
j := rand.Intn(i + 1)
reply.Answer[i], reply.Answer[j] = reply.Answer[j], reply.Answer[i]
}
return reply
}