github/portmaster
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Close HTTP response body before client reuse

Browse Source
This commit is contained in:
Patrick Pacher
2020-04-08 20:48:49 +02:00
parent cc7b1e770a
commit 47f4627f1f
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
netenv/online-status.go
View File

@@ -326,6 +326,8 @@ func checkOnlineStatus(ctx context.Context) {
// this might be a weird captive portal, just direct the user there // this might be a weird captive portal, just direct the user there
updateOnlineStatus(StatusPortal, "detectportal.firefox.com", "http request succeeded, response content not as expected") updateOnlineStatus(StatusPortal, "detectportal.firefox.com", "http request succeeded, response content not as expected")
} }
// close the body now as we plan to re-uise the http.Client
response.Body.Close()
// 3) try a https request // 3) try a https request
@@ -339,7 +341,7 @@ func checkOnlineStatus(ctx context.Context) {
response, err = client.Do(request) response, err = client.Do(request)
if err != nil { if err != nil {
// if we fail, something is really weird // if we fail, something is really weird
updateOnlineStatus(StatusSemiOnline, "", "http request failed") updateOnlineStatus(StatusSemiOnline, "", "http request failed to "+parsedHTTPSTestURL.String()+" with error "+err.Error())
return return
} }
defer response.Body.Close() defer response.Body.Close()