Add error-handling for WindowsVersion-stuff

core/core.go

@@ -1,11 +1,19 @@
 package core
 
-import "github.com/safing/portbase/modules"
+import (
+	"fmt"
+
+	"github.com/safing/portbase/modules"
+)
 
 var (
 	coreModule = modules.Register("core", nil, startCore, nil, "base", "database", "config", "api", "random")
 )
 
 func startCore() error {
+	if err := startPlatformSpecific(); err != nil {
+		return fmt.Errorf("failed to start plattform-specific stuff: %s", err)
+	}
+
 	return registerDatabases()
 }

core/os_default.go

@@ -0,0 +1,8 @@
+// +build !windows
+
+package core
+
+// only return on Fatal error!
+func startPlatformSpecific() error {
+	return nil
+}

core/os_windows.go

@@ -0,0 +1,16 @@
+package core
+
+import (
+	"github.com/safing/portbase/log"
+	"github.com/safing/portbase/utils/osdetail"
+)
+
+// only return on Fatal error!
+func startPlatformSpecific() error {
+	// We can't catch errors when calling WindowsNTVersion() in logging, so we call the function here, just to catch possible errors
+	if _, err := osdetail.WindowsNTVersion(); err != nil {
+		log.Errorf("failed to obtain WindowsNTVersion: %s", err)
+	}
+
+	return nil
+}