github/gallery-dl
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix a third(!) bug in _check_cookies() (#2372)

Browse Source 
turns out tests are worthless if you get em wrong ...
This commit is contained in:
Mike Fährmann
2022-03-18 19:52:37 +01:00
parent c4cc387f7d
commit 500a479026
2 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
gallery_dl/extractor/common.py
View File

@@ -373,7 +373,6 @@ class Extractor():
self.log.warning(
"Cookie '%s' will expire in less than %s hour%s",
cookie.name, hours + 1, "s" if hours else "")
continue
names.discard(cookie.name)
if not names:

4
test/test_cookies.py
View File

@@ -180,14 +180,14 @@ class TestCookieUtils(unittest.TestCase):
extr._cookiejar.set("a", "1", expires=now+100)
with mock.patch.object(log, "warning") as mw:
self.assertFalse(extr._check_cookies(("a",)))
self.assertTrue(extr._check_cookies(("a",)))
self.assertEqual(mw.call_count, 1)
self.assertEqual(mw.call_args[0], (
"Cookie '%s' will expire in less than %s hour%s", "a", 1, ""))
extr._cookiejar.set("a", "1", expires=now+100+7200)
with mock.patch.object(log, "warning") as mw:
self.assertFalse(extr._check_cookies(("a",)))
self.assertTrue(extr._check_cookies(("a",)))
self.assertEqual(mw.call_count, 1)
self.assertEqual(mw.call_args[0], (
"Cookie '%s' will expire in less than %s hour%s", "a", 3, "s"))