* Add ability to support different types of quotation marks
* Added normal quotation mark to list of aliases, removed single quote mark
* clean up leftover changes from testing
* change quotation mark parsing to use a map of matching pairs
* remove commented out code
* Fix conventions of the command parser utility functions
* change storage type of alias dictionary to be IReadOnlyDictionary
* revert type of CommandServiceConfig QuotationMarkAliasMap to Dictionary
* minor formatting changes to CommandParser
* remove unnecessary whitespace
* Move aliases outside of CommandInfo class
* copy IReadOnlyDictionary to ImmutableDictionary
* minor syntax changes in CommandServiceConfig
* add newline before namespace for consistency
* newline formatting tweak
* simplification of GetMatch method for CommandParser
* add more quote unicode punctuation pairs
* add check for null value when building ImmutableDictionary
* Move default alias map into a separate source file
* Ensure that the collection passed into command service is not null
commit 114e5b431b26669bcdaac9f84792a216ad67186f
Author: HelpfulStranger999 <helpfulstranger999@gmail.com>
Date: Sat Apr 28 19:08:35 2018 -0500
Fixes lack of default value for tts
commit 1fd8c70c5346ff0c4fdb0093c0fc7fb4b3c8db2c
Author: HelpfulStranger999 <helpfulstranger999@gmail.com>
Date: Sat Apr 28 15:21:11 2018 -0500
Makes text parameter of sending messages optional
* Cleaned up and refactored slightly
* Resolves#971
* Adds support for default avatars and resolves#971
* Amendment
* Final amendment
* Paginating reactions
* Amendments based on feedback
* Further amendment based on review
* Final(?) amendment
* Removes default limit and after user id
* Removes fromUserId; cleans up model creation; replaces function with individual parameters
* Copy audit logs impl from old branch and clean up
I suck at using git, so I'm gonna use brute force.
* Remove unnecessary TODOs
Category channels do not provide any new information, and the other
I forgot to remove beforehand
* Add invite update data, clean up after feedback
* Remove TODOs, add WebhookType enum for future use
WebhookType is a future-use type, as currently audit logs are the only
thing which may return it.
- Removed unnecessary parameter in SocketVoiceServer
- Moved SocketVoiceServer into Entities/Voice
- Fixed a bug where trying to download the cached guild would throw
- Fixed a potential bug where Discord might not give us a port when
connecting to voice
* Expose VoiceServerUpdate events
* Amend based on feedback
* Move this out of guild entity
* Fix namespace issue
* Adjust based on feedback #2
* Use cacheable instead
* Change based on feedback
* Initial support for invite member count arg
* Fix IDiscordClient#GetInviteAsync behavior
- Previously, the GetInviteAsync method would return null since it couldn't be parsed as a simple RestInvite object. The object should be a RestInviteMetadata instead.
* Fix methods that didn't comply with the interface
* Change with_counts REST behaviour
* Remove unnecessary JSON prop
* Remove AcceptAsync
* Allow setting IgnoreExtraArgs on an individual basis
* Remove passing in the flag as a separate parameter
* VS plz
* Push the RunMode setting out to its own attribute, because fox wants consistency.
Bonus: Removes the need for that godawful 'RunMode.Default'.
* Revert previous commit
* Fox doesn't like module-wide switches 😒
* Add EditorConfig
* Add basic .NET style rules
* Add naming rules
* Add some more extension
* Add target of the internal fields
* Fix build fails when built on macOS and Linux
* Use 'Condition' attributes
refs: 6f29dda78b (r181371650)
* Throw when attempting to modify a message not made by the current user
* Didn't realize the client is passed into the MessageHelper function
* Respond to feedback
* Update Users property for category channels
* Wrong property being used for Channels property
CategoryId is the category that "owns" this channel. That is actually impossible right now for category channels, so it returns null and get all channels wrongly.
* Resolve permissions for category
* Remove spaces
* Small fix for IChannel.GetUsersAsync
* Add guide for building the docs
* Add version to the footer of the docs
* fix links for readme
* change formatting of doc build readme
* proper capitalization of DocFX in readme
* Remove code tags around version
This resolves#987
Previous behavior was that even if `null` was passed for an embed in
UploadFileAsync, the Embed property on UploadFileArgs was still
specified - this meant we were always sending a payload_json.
If a payload_json is specified, it seems like Discord will only read
from the payload_json, and will ignore properties set outside of it.
To prevent unnecessary code duplication, this commit always specifies
parameters in the payload_json, and also will only include the embed if
one was actually specified with real data (not null).
* UnixTimestampConverter should now obey a maximum value
This change prevents an issue where the converter would be unable to
handle obscenely large timestamp values - which are actually quite
common on Discord.
OptionalConverter had to be rewritten to support checking whether or not
an InnerConverter returned an Optional. The perf impacts from this
_shouldn't_ be too bad, as types without a custom parser (which should
be the majority of Optionals in the lib) will bypass the type-check.
* optimizations on OptionalConverter
- Add a helper under CDN for cover art URLs
It would be bad practice of us to leave CDN urls hardcoded in the
deserializer, would be harder to change down the line should Spotify
ever change their CDN.
I'm not entirely supportive of leaving Spotify's CDN hardcoded in our lib
either, but there's no better alternative.
- Change SpotifyGame#Artists to an IEnumerable<string>
Seems pretty common to prefer IEnumerables in place of Arrays.
* Initial Spotify support
* Remove GameAsset#ToEntity
- appId doesn't seem to be necessary, and Spotify Game doesn't return appId either.
* Implement SpotifyGame details
* Implement song Duration prop
* Add album art CDN
* Fix ActivityType
* Remove payload debug
* Add changes according to review
+ Make `ApplicationId` nullable
+ Move ctor after props
Previously it was implemented under Discord.Net.Rest, which seems
inconsistent and unnecessary.
This also allows Commands docstrings to reference EmbedBuilder, since
Commands only has a dependency on Core.
To reply with just a rich embed, users have to invoke ReplyAsync with
`ReplyAsync("", embed: embed)`, which seems wasteful, when they only
need to specify the embed.
In f19730e4, AddModule(s)Async was changed so that the IServiceProvider
was optional, both at compile time and runtime. This had the side effect
of meaning that there was no longer a compile-time hint that users would
need to pass an IServiceProvider to AddModulesAsync. I assumed this
would not be an issue - users would recognize the runtime exception here
and self correct - but activity in our Discord support channel would
indicate otherwise.
We now require the user to explicitly opt-out of dependency injection -
they are still free to pass null in place of an IServiceProvider if they
do not intend to use one, and the library will handle this at runtime.
* Move REST requests to appropiate class
* Add call to ClientHelper and expose to public API
* Expose shard count request in public api
* Expose method from interface
* Update sharded client to utilize the new method
* Method is already implemented in a base class
* Refactor name to fit pattern for methods returning a `Task`
* Adds missing ConfigureAwait
* Corrects unnecessary whitespace
* Removes unneeded whitespace
commit a8bafb90cd1c5ea12abaa1aa01d0929833c999a8
Merge: f38dd4c4 7e04285e
Author: WamWooWam <wamwoowam@gmail.com>
Date: Mon Mar 12 08:05:52 2018 +0000
Merge branch 'dev' of https://github.com/WamWooWam/Discord.Net into dev
commit f38dd4c42149380f3f7f86c21c86cb76d0f104b7
Author: WamWooWam <wamwoowam@gmail.com>
Date: Mon Mar 12 08:05:49 2018 +0000
Cleaned up & fixed code style.
commit 7e04285e5dcc0102c9b958e75155834ca35724b9
Author: Thomas May <wamwoowam@gmail.com>
Date: Sun Mar 11 14:11:28 2018 +0000
Revert changes to DefaultRestClient
Didn't actually need to change this, whoops.
commit 3f5b2c8ef16d356e7b9588c4b36af03162ab7089
Author: WamWooWam <wamwoowam@gmail.com>
Date: Sat Mar 10 19:30:44 2018 +0000
Enabled embeds alongside uploaded files.
God damn Discord is a mess.
Co-authored-by: WamWooWam <wamwoowam@gmail.com>
IServiceProvider does not support scopes by itself - this is a behavior
introduced by Microsoft's DI container. As such, not all DI containers
may support an IScopeFactory the way that Microsoft's DI is expecting
them to.
This also means that our builtin EmptyServiceProvider does not support
scopes - meaning that users who do not use a DI container can not invoke
commands.
